From 3d9c04b336c0eade0e15517c0144f44f12ba865f Mon Sep 17 00:00:00 2001 From: HumairAK Date: Mon, 25 Jul 2016 03:40:26 -0400 Subject: Accounted for empty comment history in retrieve_userComments_history --- node_simple.js | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) (limited to 'node_simple.js') diff --git a/node_simple.js b/node_simple.js index 0290519..f7da2c3 100644 --- a/node_simple.js +++ b/node_simple.js @@ -350,16 +350,20 @@ exports.retrieve_userComments_history = function (username, callback) { _id: 0 }} ]).toArray(function (err, res) { - var finised = _.after(res.length, doCall); // execute "doCall" only after res.length # of attempts - res.forEach(function (comment) { - exams.find( { _id: ObjectId(comment.exam_id) } ).toArray(function (err, docs) { // get the exam info - comment.course_code = docs[0].course_code; - comment.year = docs[0].year; - comment.term = docs[0].term; - mylist.push(comment); // save it to array - finised(); + if(!res.length){ // Ensure a callback is executed if res is empty + callback(true, res); + }else{ + var finised = _.after(res.length, doCall); // execute "doCall" only after res.length # of attempts + res.forEach(function (comment) { + exams.find( { _id: ObjectId(comment.exam_id) } ).toArray(function (err, docs) { // get the exam info + comment.course_code = docs[0].course_code; + comment.year = docs[0].year; + comment.term = docs[0].term; + mylist.push(comment); // save it to array + finised(); + }); }); - }); + } }); function doCall() { -- cgit v1.2.3