1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
|
var chai = require('chai');
var expect = chai.expect;
var request = require('supertest');
var app;
var errorMessage = 'Parameter is not an integer';
// There are three ways to pass parameters to express:
// - as part of the URL
// - as GET parameter in the querystring
// - as POST parameter in the body
// These test show that req.checkParams are only interested in req.params values, all other
// parameters will be ignored.
function validation(req, res) {
req.checkParams({
'testparam': {
notEmpty: true,
isInt: {
errorMessage: 'Parameter is not an integer'
}
}
});
var errors = req.validationErrors();
if (errors) {
return res.send(errors);
}
res.send({ testparam: req.params.testparam });
}
function fail(body, length) {
expect(body).to.have.length(length);
expect(body[0]).to.have.property('msg', errorMessage);
}
function failMulti(body, length) {
expect(body).to.have.length(length);
expect(body[0]).to.have.property('msg', 'Invalid param');
expect(body[1]).to.have.property('msg', errorMessage);
}
function pass(body) {
expect(body).to.have.property('testparam', '42');
}
function getRoute(path, test, length, done) {
request(app)
.get(path)
.end(function(err, res) {
test(res.body, length);
done();
});
}
function postRoute(path, data, test, length, done) {
request(app)
.post(path)
.send(data)
.end(function(err, res) {
test(res.body, length);
done();
});
}
// This before() is required in each set of tests in
// order to use a new validation function in each file
before(function() {
delete require.cache[require.resolve('./helpers/app')];
app = require('./helpers/app')(validation);
});
describe('#checkParamsSchema()', function() {
describe('GET tests', function() {
it('should return one error when param does not validate as int', function(done) {
getRoute('/test', fail, 1, done);
});
it('should return two errors when param is missing', function(done) {
getRoute('/', failMulti, 2, done);
});
it('should return a success when param validates', function(done) {
getRoute('/42', pass, null, done);
});
it('should return a success when param validates and unrelated query is present', function(done) {
getRoute('/42?testparam=42', pass, null, done);
});
it('should return one error when param does not validate as int and unrelated query is present', function(done) {
getRoute('/test?testparam=blah', fail, 1, done);
});
});
describe('POST tests', function() {
it('should return one error when param does not validate as int', function(done) {
postRoute('/test', null, fail, 1, done);
});
it('should return two errors when param is missing', function(done) {
postRoute('/', null, failMulti, 2, done);
});
it('should return a success when param validates', function(done) {
postRoute('/42', null, pass, null, done);
});
it('should return a success when param validates and unrelated query is present', function(done) {
postRoute('/42?testparam=42', null, pass, null, done);
});
it('should return one error when param does not validate as int and unrelated query is present', function(done) {
postRoute('/test?testparam=blah', null, fail, 1, done);
});
// POST only
it('should return a success when param validates and unrelated query/body is present', function(done) {
postRoute('/42?testparam=blah', { testparam: 'posttest' }, pass, null, done);
});
it('should return one error when param does not validate as int and unrelated query/body is present', function(done) {
postRoute('/test?testparam=blah', { testparam: 'posttest' }, fail, 1, done);
});
it('should return two errors when param is missing and unrelated query/body is present', function(done) {
postRoute('/?testparam=blah', { testparam: 'posttest' }, failMulti, 2, done);
});
});
});
|
